Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue-2713: add version on DA stub mon page #2714

Merged
merged 5 commits into from
Dec 19, 2024
Merged

issue-2713: add version on DA stub mon page #2714

merged 5 commits into from
Dec 19, 2024

Conversation

vladstepanyuk
Copy link
Contributor

@vladstepanyuk vladstepanyuk commented Dec 17, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link
Contributor

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@komarevtsev-d komarevtsev-d added ok-to-test Label to approve test launch for external members large-tests Launch large tests for PR blockstore Add this label to run only cloud/blockstore build and tests on PR labels Dec 17, 2024
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Dec 17, 2024
@komarevtsev-d komarevtsev-d added the ok-to-test Label to approve test launch for external members label Dec 17, 2024
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Dec 17, 2024
@SvartMetal
Copy link
Collaborator

Давайте писать аббревиатуры нормально da -> DA

@vladstepanyuk vladstepanyuk changed the title issue-2713: add version on da stub mon page issue-2713: add version on DA stub mon page Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🔴 linux-x86_64-relwithdebinfo: some tests FAILED for commit 278edea.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3746 3745 0 1 0 0

komarevtsev-d
komarevtsev-d previously approved these changes Dec 18, 2024
View reviewed changes
sharpeye
sharpeye reviewed Dec 18, 2024
View reviewed changes
cloud/blockstore/libs/disk_agent/bootstrap.cpp Outdated Show resolved Hide resolved
cloud/blockstore/libs/disk_agent/bootstrap.cpp Outdated Show resolved Hide resolved
cloud/blockstore/libs/disk_agent/bootstrap.cpp Outdated Show resolved Hide resolved
@komarevtsev-d komarevtsev-d added the ok-to-test Label to approve test launch for external members label Dec 19, 2024
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Dec 19, 2024
komarevtsev-d
komarevtsev-d requested changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@komarevtsev-d komarevtsev-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Замечания тут не все исправлены

@komarevtsev-d komarevtsev-d added the ok-to-test Label to approve test launch for external members label Dec 19, 2024
@github-actions github-actions bot removed the ok-to-test Label to approve test launch for external members label Dec 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

Note

This is an automated comment that will be appended during run.

🟢 linux-x86_64-relwithdebinfo: all tests PASSED for commit d58887f.

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
3746 3746 0 0 0 0

@komarevtsev-d komarevtsev-d merged commit 40fd5fd into ydb-platform:main Dec 19, 2024
17 of 19 checks passed
@vladstepanyuk vladstepanyuk mentioned this pull request Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharpeye sharpeye sharpeye approved these changes

@komarevtsev-d komarevtsev-d komarevtsev-d approved these changes

Assignees
No one assigned
Labels
blockstore Add this label to run only cloud/blockstore build and tests on PR large-tests Launch large tests for PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vladstepanyuk @SvartMetal @sharpeye @komarevtsev-d