Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tracing for long grpc stream session requests #12493

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

UgnineSirdis
Copy link
Collaborator

Changelog entry

Stream requests are long running session requests such as topic sessions. That's why they require special handling.

  1. Long grpc streaming requests must not generate tracing sample with default settings or requests sample for database. Instead of this they must generate tracing sample of single requests inside session.
  2. Explicitly specified tracing sampling settings must generate trace sample in the same way as for usual requests
  3. Explicitly specified tracing header must be handled and produce the whole session trace as for other requests

Changelog category

  • Improvement

Additional information

...

@UgnineSirdis UgnineSirdis requested a review from a team as a code owner December 11, 2024 09:23
Copy link

github-actions bot commented Dec 11, 2024

2024-12-11 09:28:11 UTC Pre-commit check linux-x86_64-relwithdebinfo for f56de22 has started.
2024-12-11 09:28:22 UTC Artifacts will be uploaded here
2024-12-11 09:31:25 UTC ya make is running...
🟡 2024-12-11 10:39:44 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
32641 29719 0 3 2810 109

2024-12-11 10:42:28 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-12-11 10:54:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
652 (only retried tests) 543 0 2 0 107

2024-12-11 10:54:43 UTC ya make is running... (failed tests rerun, try 3)
🔴 2024-12-11 11:06:49 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
649 (only retried tests) 540 0 2 0 107

🟢 2024-12-11 11:06:59 UTC Build successful.
🟢 2024-12-11 11:07:19 UTC ydbd size 2.1 GiB changed* by -6.3 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: e838a62 merge: f56de22 diff diff %
ydbd size 2 255 721 664 Bytes 2 249 130 624 Bytes -6.3 MiB -0.292%
ydbd stripped size 483 873 296 Bytes 482 148 496 Bytes -1.6 MiB -0.356%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Dec 11, 2024

2024-12-11 09:28:25 UTC Pre-commit check linux-x86_64-release-asan for f56de22 has started.
2024-12-11 09:28:36 UTC Artifacts will be uploaded here
2024-12-11 09:31:38 UTC ya make is running...
🟡 2024-12-11 10:52:00 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15221 15147 0 24 4 46

🟢 2024-12-11 10:53:15 UTC Build successful.
🟢 2024-12-11 10:53:38 UTC ydbd size 3.6 GiB changed* by -11.6 MiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: e838a62 merge: f56de22 diff diff %
ydbd size 3 897 699 800 Bytes 3 885 558 160 Bytes -11.6 MiB -0.312%
ydbd stripped size 1 366 522 384 Bytes 1 360 716 272 Bytes -5.5 MiB -0.425%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant