Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualFileSystem.get_virtual_file() will return a VirtualFile for a path to a directory #3

Open
joachimmetz opened this issue Feb 2, 2019 · 2 comments

Comments

@joachimmetz
Copy link
Collaborator

VirtualFileSystem.get_virtual_file() will return a VirtualFile for a path to a directory

Unclear from the code and docstring what the intended behavior is

@ydkhatri
Copy link
Owner

ydkhatri commented Feb 3, 2019

That should have said ..path to a file instead of ..path to a directory. It will create an object of type VirtualFile and return it.
I will change the description to a better one.

@joachimmetz
Copy link
Collaborator Author

Or adding a docstring with some additional checks to see path points to file could help as well. Per email I would focus on adding tests first, then have a closer look at improving the interfaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants