Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read mesh coordinates from the input file by default #69

Open
4 tasks done
martijnende opened this issue Sep 6, 2022 · 0 comments · May be fixed by #84
Open
4 tasks done

Read mesh coordinates from the input file by default #69

martijnende opened this issue Sep 6, 2022 · 0 comments · May be fixed by #84
Labels
feature Contributions related to new features

Comments

@martijnende
Copy link
Collaborator

martijnende commented Sep 6, 2022

Currently QDYN internally generates a mesh, except for 3D MPI simulations. Since the Python wrapper already pre-computes a mesh with default settings, we might as well shift the burden from FORTRAN to Python/Matlab, and always read the mesh from the input file.

To-do

  • Verify that the default mesh generator in Python outputs the same results as the one in FORTRAN
  • Create Python routines for standard fault configurations
  • Create an internal check that the along-strike direction is co-linear for each row of the mesh, and that the number of elements in that direction is an integer power of 2 (both are required by the FFT)
  • Design an integration test for an unambiguous fault geometry (i.e. mesh in == mesh out)
@martijnende martijnende added the feature Contributions related to new features label Sep 6, 2022
@martijnende martijnende linked a pull request Sep 23, 2022 that will close this issue
@martijnende martijnende linked a pull request May 31, 2023 that will close this issue
@martijnende martijnende removed a link to a pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Contributions related to new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant