Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please make pip installable #1

Open
natevw opened this issue Sep 2, 2014 · 5 comments
Open

Please make pip installable #1

natevw opened this issue Sep 2, 2014 · 5 comments

Comments

@natevw
Copy link
Contributor

natevw commented Sep 2, 2014

I'd appreciate being able to add this plugin to my pip_requirements.txt rather than making a copy of a dependency into my own repo. If this is what your PyPI discussion is about, I'd ask you to reconsider — maybe this is just npm rubbing off on me, but just because a good solution to a problem has low SLOC doesn't mean I want to start cut-and-pasting it alongside my own code.
natevw added a commit to natevw/django-sameas that referenced this issue Sep 2, 2014
@natevw
Adds package metadata via setup.py
b68077d 
I based this on an example at http://guide.python-distribute.org/creation.html with your GitHub project/user info. I went out on a limb and said it requires Django 1.4 based on your claim that it works on 1.5 and likely earlier.

This file seems to be all that's necessary to `pip install` via a repo URL and should make submission to PyPI (ydm#1) much easier for even simpler re-use of this code.
@natevw natevw mentioned this issue Sep 2, 2014
Merged
@natevw
Copy link
Contributor Author

natevw commented Sep 2, 2014

As a workaround I am able to add this line to my pip_requirements.txt:

git+https://github.com/natevw/django-sameas.git@patch-1#egg=django-sameas

Thanks for this library, by the way! Found it via https://code.djangoproject.com/ticket/9256#comment:10

@dmarcelino
Copy link
Contributor

@ydm, django-sameas is of valuable help, I'm using it now on a django 1.10 project. Please reconsider publishing it to pypi.

@ydm
Copy link
Owner

ydm commented Feb 7, 2018

I'm happy you guys find it useful. Send a pull request that makes it pip/pypi installable and I'll be more than happy to merge it.

@dmarcelino
Copy link
Contributor

Hey @ydm,

I've noticed you've merged PR #6. Please let us know when you publish django-sameas to PyPi. I'm happy to help in case anything is amiss.

I've also submitted PR #7 so any new PRs can be automatically tested by travis.

Cheers

ydm pushed a commit that referenced this issue Feb 22, 2018
@dmarcelino
Merge pull request #1 from dmarcelino/runtests
e74395b 
Runtests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@natevw @ydm @dmarcelino and others