Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comprehensive correctness tests #4

Open
yds12 opened this issue Jan 23, 2022 · 2 comments
Open

Comprehensive correctness tests #4

yds12 opened this issue Jan 23, 2022 · 2 comments
Labels
testing Anything related to tests

Comments

@yds12
Copy link
Owner

yds12 commented Jan 23, 2022

We are just testing a few examples so far, with unit tests. This approach is not enough to guarantee that eval is 99.99% bug-free. Use something more thorough like quickcheck for that. If necessary, we can check the results of eval against other libraries such as meval.

@yds12 yds12 added the testing Anything related to tests label Jan 23, 2022
@yds12
Copy link
Owner Author

yds12 commented Sep 9, 2022

We are already doing enough to close this issue:

  • fuzz tests;
  • tests with random valid input (using glc);
  • comparison of results with other libraries (in the glc tests and in benchmarks).

@yds12 yds12 closed this as completed Sep 9, 2022
@yds12
Copy link
Owner Author

yds12 commented Sep 10, 2022

One last kind of test we can add is one similar to the one with glc, but instead of generating valid expressions, we would generate invalid (but "almost valid") input and see if they are all rejected (with Err, never panic).

@yds12 yds12 reopened this Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to tests
Projects
None yet
Development

No branches or pull requests

1 participant