Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify own deadline when borrowing, repaying and withdrawing #1

Open
nourharidy opened this issue Oct 16, 2020 · 0 comments

Comments

@nourharidy
Copy link

nourharidy commented Oct 16, 2020

Because the swap deadline is not specified by the user, it is instead manually set to 30 minutes after the transaction is included in the block. This does not prevent the transaction from being included 30 minutes after it is sent by the user.

Allowing the user to specify a deadline timestamp when calling repay and borrow functions would solve this problem.

https://github.com/iearn-finance/ycredit.finance/blob/9b72bd0ad3365f66f6fc969f96c917fc242611e7/contracts/StableCreditProtocol.sol#L275

https://github.com/iearn-finance/ycredit.finance/blob/9b72bd0ad3365f66f6fc969f96c917fc242611e7/contracts/StableCreditProtocol.sol#L292

https://github.com/iearn-finance/ycredit.finance/blob/9b72bd0ad3365f66f6fc969f96c917fc242611e7/contracts/StableCreditProtocol.sol#L308

https://github.com/iearn-finance/ycredit.finance/blob/9b72bd0ad3365f66f6fc969f96c917fc242611e7/contracts/StableCreditProtocol.sol#L324

https://github.com/iearn-finance/ycredit.finance/blob/9b72bd0ad3365f66f6fc969f96c917fc242611e7/contracts/StableCreditProtocol.sol#L408

@nourharidy nourharidy changed the title Allow user to specify own deadline when borrowing and repaying Allow user to specify own deadline when borrowing, repaying and withdrawing Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant