You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because the swap deadline is not specified by the user, it is instead manually set to 30 minutes after the transaction is included in the block. This does not prevent the transaction from being included 30 minutes after it is sent by the user.
Allowing the user to specify a deadline timestamp when calling repay and borrow functions would solve this problem.
The text was updated successfully, but these errors were encountered:
nourharidy
changed the title
Allow user to specify own deadline when borrowing and repaying
Allow user to specify own deadline when borrowing, repaying and withdrawing
Oct 16, 2020
Because the swap deadline is not specified by the user, it is instead manually set to 30 minutes after the transaction is included in the block. This does not prevent the transaction from being included 30 minutes after it is sent by the user.
Allowing the user to specify a deadline timestamp when calling repay and borrow functions would solve this problem.
https://github.com/iearn-finance/ycredit.finance/blob/9b72bd0ad3365f66f6fc969f96c917fc242611e7/contracts/StableCreditProtocol.sol#L275
https://github.com/iearn-finance/ycredit.finance/blob/9b72bd0ad3365f66f6fc969f96c917fc242611e7/contracts/StableCreditProtocol.sol#L292
https://github.com/iearn-finance/ycredit.finance/blob/9b72bd0ad3365f66f6fc969f96c917fc242611e7/contracts/StableCreditProtocol.sol#L308
https://github.com/iearn-finance/ycredit.finance/blob/9b72bd0ad3365f66f6fc969f96c917fc242611e7/contracts/StableCreditProtocol.sol#L324
https://github.com/iearn-finance/ycredit.finance/blob/9b72bd0ad3365f66f6fc969f96c917fc242611e7/contracts/StableCreditProtocol.sol#L408
The text was updated successfully, but these errors were encountered: