Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abbreviated.java:83-87: Introduce text.Flatten that... #1460

Closed
0pdd opened this issue Sep 13, 2020 · 10 comments
Closed

Abbreviated.java:83-87: Introduce text.Flatten that... #1460

0pdd opened this issue Sep 13, 2020 · 10 comments
Assignees
Milestone

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 13, 2020

The puzzle 1287-014a5155 from #1287 has to be resolved:

* @todo #1287:30min Introduce `text.Flatten` that takes a `Scalar` of `Text`
* and call `value()` then `asString()` on it. Add some tests for it (including
* for `equals`). Then replace the code below by a composition of `text.Flatten`
* and `scalar.Ternary`. Then do the same for `PrefixOf` and `SuffixOf` using
* `text.Sub`.

The puzzle was created by Victor Noël on 13-Sep-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd
Copy link
Collaborator Author

0pdd commented Sep 13, 2020

This puzzle inherited milestone 1.0 from issue #1287.

@victornoel
Copy link
Collaborator

@0crat assign me

@victornoel
Copy link
Collaborator

@0crat wait for #1475 to be done first.

@victornoel
Copy link
Collaborator

@0crat wait for #1515

victornoel added a commit to victornoel/cactoos that referenced this issue Dec 27, 2020
@0crat
Copy link
Collaborator

0crat commented Dec 27, 2020

@0crat wait for #1515 (here)

@victornoel Job #1460 is already on hold

victornoel added a commit to victornoel/cactoos that referenced this issue Dec 27, 2020
@andreoss
Copy link
Contributor

@victornoel It's not quite clear why calling .value() directly in order to get Text is undesirable.

@victornoel
Copy link
Collaborator

@andreoss I don't understand the question, can you clarify?

victornoel added a commit to victornoel/cactoos that referenced this issue Dec 28, 2020
victornoel added a commit to victornoel/cactoos that referenced this issue Dec 28, 2020
victornoel added a commit to victornoel/cactoos that referenced this issue Dec 28, 2020
victornoel added a commit to victornoel/cactoos that referenced this issue Dec 28, 2020
@0pdd
Copy link
Collaborator Author

0pdd commented Jan 10, 2021

The puzzle 1287-014a5155 has disappeared from the source code, that's why I closed this issue.

@victornoel
Copy link
Collaborator

@0crat status

@0crat
Copy link
Collaborator

0crat commented Jan 10, 2021

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants