Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Capitalized EE version of StringUtils.capitalize #1466

Closed
kokodyn opened this issue Sep 18, 2020 · 5 comments
Closed

Add Capitalized EE version of StringUtils.capitalize #1466

kokodyn opened this issue Sep 18, 2020 · 5 comments

Comments

@kokodyn
Copy link
Contributor

kokodyn commented Sep 18, 2020

Hi all
I would like to add EO version of StringUtils.capitalize
StringUtils.capitalize
But it's seems first I need to add class "Titled" to handle title case converting.
Is it ok for you?

I hope for your understanding, this is my first pull request to open source project.

@victornoel
Copy link
Collaborator

@kokodyn I'm not exactly sure what you mean :)

I see there is #1465 which introduce Capitalized: is this PR outdated? It seems to implement Capitalized as you want it, no? Or do you mean that to simplify the PR, you would need Titled?

@victornoel
Copy link
Collaborator

@kokodyn can you explain?

@victornoel
Copy link
Collaborator

@kokodyn from what I understand, I believe we can handle all of that from the PR you made, see my comment #1465 (comment). No need for a new ticket :)

@kokodyn
Copy link
Contributor Author

kokodyn commented Sep 27, 2020

@victornoel
To simplify logic I created new PR to introduce Titled.

@victornoel
Copy link
Collaborator

@kokodyn I'm going to close this then. Please next time try to take things in the right order either by creating first a ticket for a new requirement not supported by cactoos or if you contribute a PR, by going iteratively and incrementally with @todos.

We are in no rush to get PRs and solutions, we must first examine the problems as they come :)

By the way @kokodyn, woudln't you be interested in joining zerocracy and the cactoos project in order to contribute to it as part of the team? It would be great to have more DEV :)
See http://www.zerocracy.com/faq.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants