Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KG-augmented decoding is not applied #3

Open
zhaochaocs opened this issue Feb 14, 2021 · 6 comments
Open

KG-augmented decoding is not applied #3

zhaochaocs opened this issue Feb 14, 2021 · 6 comments

Comments

@zhaochaocs
Copy link

Hello Ye, thanks for making the code public.

Not sure if I understand correctly, but from here it seems that the KG-augmented decoding layers are not applied during decoding. Could you let me know if there is anything I missed?

Also, could you check if there is any issue in the DecoderGATLayer? For example, from here, ex_entity may not be converted to embeddings before feeding into the exent_proj function.

Thanks again for the help.

@wyu97
Copy link

wyu97 commented Feb 17, 2021

I have the same question. I found class DecoderGATLayer is not utilized in the KG-BART decoder.

@ana3A
Copy link

ana3A commented May 28, 2021

Have you come to some conclusion about this?
Thank you in advance.

@leileilin
Copy link

Hello Ye, thanks for making the code public.

Not sure if I understand correctly, but from here it seems that the KG-augmented decoding layers are not applied during decoding. Could you let me know if there is anything I missed?

Also, could you check if there is any issue in the DecoderGATLayer? For example, from here, ex_entity may not be converted to embeddings before feeding into the exent_proj function.

Thanks again for the help.

in the paper, the author did not use that layer in the pretraining process.
I don't know if you mean the pretraining stage.

@JasmineJiali
Copy link

Same question here, and it looks like the decoder in the code does not work as the decoder in the paper. In the paper, a concept needs to concatenate with each of its expanded entity, but in the code, it only concatenates once.

@JasmineJiali
Copy link

@yeliu918 Could you have a look and explain the code a little bit? I am interested in your work but have trouble reproducing it based on the code you gave. Thx a lot!!

@alexnotes
Copy link

@yeliu918 could you explain this? in decoder module in your paper, you say MHGAT is adopted. MHGAT corresponds to DecoderGATLayer class in your code, but it's not used actually. Why? is there any miswriting error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants