ensure 2 digit sets in string to hex conversion fixing Google 2FA issues

README.md

@@ -240,6 +240,7 @@ Base32 decoding
 
 | Version    | Notes       |
 |:-----------|:------------|
+| 1.1.2      | Bug in string to hex conversion resulting in failed Google Apps Code Generation|
 | 1.1.1      | Bug in decoding (uppercase) resulting in unsync tokens + jshint fixes|
 | 1.1.0      | Added check function to core and readme change |
 | 1.0.0      | Stable Release |

lib/components/googleAuthenticator.js

@@ -111,7 +111,7 @@ var googleAuthenticator = {
 
   // Base32 encoding
   encode: function encode(secret) {
-    return base32.encode(secret).toUpperCase();
+    return base32.encode(secret).replace(/=/g,'');
   },
 
 

lib/components/otplib.js

@@ -252,10 +252,16 @@ otplib.prototype.helpers = {
 
   // Converts String to Hex
   stringToHex: function stringToHex(value) {
-    var _hex = '';
+    var _hex = '',
+        _tmp = '';
 
     for (var i = 0; i < value.length; i++){
-      _hex += '' + value.charCodeAt(i).toString(16);
+
+      // Convert to Hex and Ensure it's in 2 digit sets
+      _tmp = ('0000' + value.charCodeAt(i).toString(16)).slice(-2);
+
+      // Append
+      _hex += '' + _tmp;
     }
 
     return _hex;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "otplib",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "main": "lib/index.js",
   "description": "HMAC-based (HOTP) and Time-based (TOTP) One-Time Password library",
   "homepage": "https://github.com/yeojz/otplib",
@@ -22,7 +22,7 @@
   "files": [
     ""
   ],
-  "keywords": ["otp", "totp", "hotp", "one time password", "google authenticator", "authentication"],
+  "keywords": ["otp", "totp", "hotp", "one time password", "google authenticator", "authentication", "2FA", "2 factor"],
   "devDependencies": {
     "grunt-contrib-jshint": "~0.7.0",
     "grunt-contrib-nodeunit": "~0.2.0",