Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gen-certs.sh for cmake as well #1943

Closed
wants to merge 1 commit into from

Conversation

opoplawski
Copy link

Fixes #1798 for cmake. This also runs the tests in the test/ directory for cmake.

@yhirose
Copy link
Owner

yhirose commented Sep 19, 2024

@opoplawski thanks for the pull request.
@sum01 @jimmy-park could you review it for me?

Copy link
Contributor

@sum01 sum01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess technically the tests run with Cmake will no longer cross-platform since it uses the bash script. I assume no one really cares though.

LGTM, all tests passed on my machine.

@jimmy-park
Copy link
Contributor

If HTTPLIB_IS_USING_OPENSSL and HTTPLIB_TEST are ON on some Windows machines (my machine, actually), CMake configuration will fail.

@yhirose
Copy link
Owner

yhirose commented Sep 19, 2024

@opoplawski could you make an adjustment according to @jimmy-park's comment?

@opoplawski
Copy link
Author

Hmm, for cross platform support I think the meson style approach will be needed here. Unfortunately I don't have the time or interest for that so I'll leave that to someone else. Hopefully you can use the _OPENSSL_VERSION cmake variable for checks.

@opoplawski opoplawski closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSLClientServerTest.* tests fail with OpenSSL 3.2.1
4 participants