Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PdoConnectionInterface::getActivePDO() should return PDO #908

Open
vjik opened this issue Dec 6, 2024 · 0 comments
Open

PdoConnectionInterface::getActivePDO() should return PDO #908

vjik opened this issue Dec 6, 2024 · 0 comments

Comments

@vjik
Copy link
Member

vjik commented Dec 6, 2024

Currently return type is nullable:

public function getActivePDO(string $sql = '', bool $forRead = null): PDO|null;

From phpdoc:

This method will open the DB connection and then return {@see PDO}.

Abstract class AbstractPdoConnection also always returns PDO:

public function getActivePDO(string|null $sql = '', bool|null $forRead = null): PDO

@samdark samdark changed the title PdoConnectionInterface::getActivePDO() should returns PDO PdoConnectionInterface::getActivePDO() should return PDO Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant