From b80bac0a73bca1bb19920facd76f158e0711e7e1 Mon Sep 17 00:00:00 2001
From: Dmitrii Derepko <xepozz@list.ru>
Date: Sun, 23 Jun 2024 14:20:52 +0300
Subject: [PATCH 01/10] Simplify creating error string

---
 src/ErrorHandler.php               |  2 +-
 src/Renderer/PlainTextRenderer.php | 23 ++++++++++++++++++++---
 2 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/src/ErrorHandler.php b/src/ErrorHandler.php
index 7f0c575..2a7d4b3 100644
--- a/src/ErrorHandler.php
+++ b/src/ErrorHandler.php
@@ -62,7 +62,7 @@ public function handle(
         $renderer ??= $this->defaultRenderer;
 
         try {
-            $this->logger->error((string) (new PlainTextRenderer())->renderVerbose($t, $request), ['throwable' => $t]);
+            $this->logger->error(PlainTextRenderer::throwableToString($t), ['throwable' => $t]);
             return $this->debug ? $renderer->renderVerbose($t, $request) : $renderer->render($t, $request);
         } catch (Throwable $t) {
             return new ErrorData((string) $t);
diff --git a/src/Renderer/PlainTextRenderer.php b/src/Renderer/PlainTextRenderer.php
index 32982c3..d5e80c6 100644
--- a/src/Renderer/PlainTextRenderer.php
+++ b/src/Renderer/PlainTextRenderer.php
@@ -22,9 +22,26 @@ public function render(Throwable $t, ServerRequestInterface $request = null): Er
     public function renderVerbose(Throwable $t, ServerRequestInterface $request = null): ErrorData
     {
         return new ErrorData(
-            $t::class . " with message '{$t->getMessage()}' \n\nin "
-            . $t->getFile() . ':' . $t->getLine() . "\n\n"
-            . "Stack trace:\n" . $t->getTraceAsString()
+            $this->throwableToString($t)
+        );
+    }
+
+    public static function throwableToString(Throwable $t): string
+    {
+        return sprintf(
+            <<<TEXT
+                %s with message "%s"
+
+                in %s:%s
+
+                Stack trace:
+                %s
+                TEXT,
+            $t::class,
+            $t->getMessage(),
+            $t->getFile(),
+            $t->getLine(),
+            $t->getTraceAsString()
         );
     }
 }

From 0c98e8501cb40e1002f7d61418676fcf0fbebe1b Mon Sep 17 00:00:00 2001
From: StyleCI Bot <bot@styleci.io>
Date: Sun, 23 Jun 2024 11:21:11 +0000
Subject: [PATCH 02/10] Apply fixes from StyleCI

---
 src/Exception/ErrorException.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Exception/ErrorException.php b/src/Exception/ErrorException.php
index e79db27..02a2451 100644
--- a/src/Exception/ErrorException.php
+++ b/src/Exception/ErrorException.php
@@ -113,7 +113,7 @@ private function addXDebugTraceToFatalIfAvailable(): void
                 $trace[] = $frame;
             }
 
-            $ref = new ReflectionProperty(\Exception::class, 'trace');
+            $ref = new ReflectionProperty(Exception::class, 'trace');
             $ref->setAccessible(true);
             $ref->setValue($this, $trace);
         }

From 1f673740ade4e4985a0c5f1fcc9d581439e11e7b Mon Sep 17 00:00:00 2001
From: xepozz <xepozz@users.noreply.github.com>
Date: Sun, 23 Jun 2024 12:44:09 +0000
Subject: [PATCH 03/10] Apply Rector changes (CI)

---
 src/Renderer/PlainTextRenderer.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Renderer/PlainTextRenderer.php b/src/Renderer/PlainTextRenderer.php
index d5e80c6..76fc39a 100644
--- a/src/Renderer/PlainTextRenderer.php
+++ b/src/Renderer/PlainTextRenderer.php
@@ -22,7 +22,7 @@ public function render(Throwable $t, ServerRequestInterface $request = null): Er
     public function renderVerbose(Throwable $t, ServerRequestInterface $request = null): ErrorData
     {
         return new ErrorData(
-            $this->throwableToString($t)
+            self::throwableToString($t)
         );
     }
 

From f99da261a7e16c15a9607f457bbc572b39abffbf Mon Sep 17 00:00:00 2001
From: Dmitrii Derepko <xepozz@list.ru>
Date: Mon, 24 Jun 2024 15:45:25 +0300
Subject: [PATCH 04/10] Show full argument by click

---
 src/Renderer/HtmlRenderer.php  |  8 +++---
 templates/_call-stack-item.php | 13 +++++++---
 templates/development.css      | 10 +++++++-
 templates/development.php      | 45 +++++++++++++++++++++++++++++++---
 4 files changed, 64 insertions(+), 12 deletions(-)

diff --git a/src/Renderer/HtmlRenderer.php b/src/Renderer/HtmlRenderer.php
index b3449d5..4f9ad07 100644
--- a/src/Renderer/HtmlRenderer.php
+++ b/src/Renderer/HtmlRenderer.php
@@ -276,7 +276,7 @@ public function renderCallStack(Throwable $t): string
      *
      * @return string The string representation of the arguments array.
      */
-    public function argumentsToString(array $args): string
+    public function argumentsToString(array $args, bool $truncate): string
     {
         $count = 0;
         $isAssoc = $args !== array_values($args);
@@ -287,7 +287,7 @@ public function argumentsToString(array $args): string
         foreach ($args as $key => $value) {
             $count++;
 
-            if ($count >= 5) {
+            if ($truncate && $count >= 5) {
                 if ($count > 5) {
                     unset($args[$key]);
                 } else {
@@ -302,7 +302,7 @@ public function argumentsToString(array $args): string
                 $args[$key] = '<span class="keyword">' . ($value ? 'true' : 'false') . '</span>';
             } elseif (is_string($value)) {
                 $fullValue = $this->htmlEncode($value);
-                if (mb_strlen($value, 'UTF-8') > 32) {
+                if ($truncate && mb_strlen($value, 'UTF-8') > 32) {
                     $displayValue = $this->htmlEncode(mb_substr($value, 0, 32, 'UTF-8')) . '...';
                     $args[$key] = "<span class=\"string\" title=\"$fullValue\">'$displayValue'</span>";
                 } else {
@@ -310,7 +310,7 @@ public function argumentsToString(array $args): string
                 }
             } elseif (is_array($value)) {
                 unset($args[$key]);
-                $args[$key] = '[' . $this->argumentsToString($value) . ']';
+                $args[$key] = '[' . $this->argumentsToString($value, $truncate) . ']';
             } elseif ($value === null) {
                 $args[$key] = '<span class="keyword">null</span>';
             } elseif (is_resource($value)) {
diff --git a/templates/_call-stack-item.php b/templates/_call-stack-item.php
index 4a55ff5..d4bb752 100644
--- a/templates/_call-stack-item.php
+++ b/templates/_call-stack-item.php
@@ -33,9 +33,16 @@
 
             <?php if ($function !== null): ?>
                 <span class="function-info">
-                    <?= $file === null ? "{$index}." : '&ndash;' ?>
-                    <?php $function = $class === null ? $function : "$class::$function" ?>
-                    <?= "{$this->htmlEncode($function)}({$this->argumentsToString($args)})" ?>
+                    <?php
+                    echo $file === null ? "{$index}." : '&ndash;';
+                    $function = $class === null ? $function : "$class::$function";
+
+                    echo '<span class="function">' . $this->htmlEncode($function) . '</span>';
+                    echo '<span class="arguments">(';
+                    echo '<span class="short-arguments">' . $this->argumentsToString($args, true) . '</span>';
+                    echo '<span class="full-arguments hidden">' . $this->argumentsToString($args, false) . '</span>';
+                    echo ')</span>';
+                    ?>
                 </span>
             <?php endif ?>
         </div>
diff --git a/templates/development.css b/templates/development.css
index 2a5ca02..7533c13 100644
--- a/templates/development.css
+++ b/templates/development.css
@@ -383,6 +383,10 @@ main {
     }
 }
 
+.hidden {
+    display: none;
+}
+
 .flex-1 {
     flex: 1;
 }
@@ -453,11 +457,15 @@ main {
     color: var(--element-wrap-text-color);
 }
 
-.call-stack ul li .element-wrap:hover .file-name,
+.call-stack ul li .element-wrap .file-name:hover,
 .call-stack ul li .element-code-wrap .code-wrap .lines-item:hover {
     color: var(--element-wrap-hover-text-color);
 }
 
+.call-stack ul li .arguments:hover {
+    color: var(--element-wrap-hover-text-color);
+}
+
 .call-stack ul li .element-wrap .function-info {
     display: inline-block;
 }
diff --git a/templates/development.php b/templates/development.php
index 5b61714..23c8498 100644
--- a/templates/development.php
+++ b/templates/development.php
@@ -161,8 +161,8 @@
 </script>
 <script>
     window.onload = function() {
-        var codeBlocks = document.querySelectorAll('.solution pre code,.codeBlock'),
-            callStackItems = document.getElementsByClassName('call-stack-item');
+        const codeBlocks = document.querySelectorAll('.solution pre code,.codeBlock');
+        const callStackItems = document.getElementsByClassName('call-stack-item');
 
         // If there are grouped vendor package files
         var vendorCollapse = document.getElementsByClassName('call-stack-vendor-collapse');
@@ -221,13 +221,49 @@
         };
 
         for (var i = 0, imax = callStackItems.length; i < imax; ++i) {
-            refreshCallStackItemCode(callStackItems[i]);
+            let stackItem = callStackItems[i];
+            refreshCallStackItemCode(stackItem);
 
             // toggle code block visibility
-            callStackItems[i].getElementsByClassName('element-wrap')[0].addEventListener('click', function (event) {
+            stackItem.querySelector('.show-arguments-toggle')?.addEventListener('click', function (e) {
+                e.stopPropagation()
+                console.log('click')
+                // function-arguments-wrap
+
+                stackItem.getElementsByClassName('function-arguments-wrap')[0].classList.toggle('hidden')
+            });
+
+            // toggle code block visibility
+            const arguments = stackItem.querySelector('.arguments');
+            arguments?.addEventListener('select', function (e) {
+                e.stopPropagation()
+                e.stopImmediatePropagation()
+
+            })
+            arguments?.addEventListener('click', function (e) {
+                e.stopPropagation()
+                // stop click event on selecting text
+                if (document.getSelection()?.type === 'Range') {
+                    return
+                }
+
+                const fullArguments = stackItem.querySelector('.full-arguments');
+                const shortArguments = stackItem.querySelector('.short-arguments');
+                if (fullArguments) {
+                    fullArguments.classList.toggle('hidden')
+                    shortArguments.classList.toggle('hidden')
+                }
+            });
+
+            // toggle code block visibility
+            stackItem.getElementsByClassName('element-wrap')[0].addEventListener('click', function (event) {
                 if (event.target.nodeName.toLowerCase() === 'a') {
                     return;
                 }
+                // stop click event on selecting text
+                if (document.getSelection()?.type === 'Range') {
+                    return
+                }
 
                 var callStackItem = this.parentNode,
                     code = callStackItem.getElementsByClassName('code-wrap')[0];
@@ -245,6 +281,7 @@
                     refreshCallStackItemCode(callStackItem);
                 }
             });
+
         }
 
         // handle copy stacktrace action on clipboard button

From 2b56534c10a7dad3c9273011ee5866429f690974 Mon Sep 17 00:00:00 2001
From: Dmitrii Derepko <xepozz@list.ru>
Date: Mon, 24 Jun 2024 15:52:10 +0300
Subject: [PATCH 05/10] Fix tests

---
 tests/Renderer/PlainTextRendererTest.php | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/tests/Renderer/PlainTextRendererTest.php b/tests/Renderer/PlainTextRendererTest.php
index 1645ed2..39964e1 100644
--- a/tests/Renderer/PlainTextRendererTest.php
+++ b/tests/Renderer/PlainTextRendererTest.php
@@ -22,12 +22,24 @@ public function testRenderVerbose(): void
     {
         $renderer = new PlainTextRenderer();
         $throwable = new RuntimeException();
-        $data = $renderer->renderVerbose($throwable);
-        $content = RuntimeException::class . " with message '{$throwable->getMessage()}' \n\nin "
-            . $throwable->getFile() . ':' . $throwable->getLine() . "\n\n"
-            . "Stack trace:\n" . $throwable->getTraceAsString()
-        ;
+        $expectedContent = sprintf(
+            <<<TEXT
+                %s with message "%s"
+
+                in %s:%s
 
-        $this->assertSame($content, (string) $data);
+                Stack trace:
+                %s
+                TEXT,
+            $throwable::class,
+            $throwable->getMessage(),
+            $throwable->getFile(),
+            $throwable->getLine(),
+            $throwable->getTraceAsString()
+        );
+
+        $data = $renderer->renderVerbose($throwable);
+        $this->assertSame($expectedContent, (string) $data);
+        $this->assertSame($expectedContent, PlainTextRenderer::throwableToString($throwable));
     }
 }

From 71e87cbd9497de3933fb15e65c8477595eea917e Mon Sep 17 00:00:00 2001
From: Dmitrii Derepko <xepozz@list.ru>
Date: Mon, 24 Jun 2024 15:55:30 +0300
Subject: [PATCH 06/10] Add changelog

---
 CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index cb96398..a6b5d75 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,7 +2,7 @@
 
 ## 3.2.2 under development
 
-- no changes in this release.
+- Enh #113: Simplify error log (@xepozz)
 
 ## 3.2.1 March 07, 2024
 

From e22d0943daab0d6dfc9766bcc686da8bb894392e Mon Sep 17 00:00:00 2001
From: Dmitrii Derepko <xepozz@list.ru>
Date: Mon, 24 Jun 2024 15:56:37 +0300
Subject: [PATCH 07/10] Add changelog

---
 CHANGELOG.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index a6b5d75..ada10cc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## 3.2.2 under development
 
+- Bug #114: Stop `click` event on text selection (@xepozz)
+- Enh #114: Show full argument by click (@xepozz)
 - Enh #113: Simplify error log (@xepozz)
 
 ## 3.2.1 March 07, 2024

From 95b26fa463b606112c39409f7fa97a68e9c2044a Mon Sep 17 00:00:00 2001
From: Dmitrii Derepko <xepozz@list.ru>
Date: Mon, 24 Jun 2024 15:58:24 +0300
Subject: [PATCH 08/10] Fix bc

---
 src/Renderer/HtmlRenderer.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Renderer/HtmlRenderer.php b/src/Renderer/HtmlRenderer.php
index 400e0da..789e3fa 100644
--- a/src/Renderer/HtmlRenderer.php
+++ b/src/Renderer/HtmlRenderer.php
@@ -282,7 +282,7 @@ public function renderCallStack(Throwable $t, array $trace = []): string
      *
      * @return string The string representation of the arguments array.
      */
-    public function argumentsToString(array $args, bool $truncate): string
+    public function argumentsToString(array $args, bool $truncate = true): string
     {
         $count = 0;
         $isAssoc = $args !== array_values($args);

From a4aedd7a823b45174bb58ae9049c1a0c7ce9cd0e Mon Sep 17 00:00:00 2001
From: Dmitrii Derepko <xepozz@list.ru>
Date: Sun, 30 Jun 2024 18:48:54 +0300
Subject: [PATCH 09/10] Fix missing space

---
 templates/_call-stack-item.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/templates/_call-stack-item.php b/templates/_call-stack-item.php
index d4bb752..21ec286 100644
--- a/templates/_call-stack-item.php
+++ b/templates/_call-stack-item.php
@@ -34,7 +34,7 @@
             <?php if ($function !== null): ?>
                 <span class="function-info">
                     <?php
-                    echo $file === null ? "{$index}." : '&ndash;';
+                    echo $file === null ? "{$index}." : '&mdash;&nbsp;';
                     $function = $class === null ? $function : "$class::$function";
 
                     echo '<span class="function">' . $this->htmlEncode($function) . '</span>';

From f9bd5d420416d0e04d50b34b507e7d99c1c8a8b2 Mon Sep 17 00:00:00 2001
From: Dmitrii Derepko <xepozz@list.ru>
Date: Sun, 30 Jun 2024 20:18:15 +0300
Subject: [PATCH 10/10] Clean code

---
 templates/development.php | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/templates/development.php b/templates/development.php
index e1e279a..38ae759 100644
--- a/templates/development.php
+++ b/templates/development.php
@@ -255,8 +255,6 @@ class="copy-clipboard"
             // toggle code block visibility
             stackItem.querySelector('.show-arguments-toggle')?.addEventListener('click', function (e) {
                 e.stopPropagation()
-                console.log('click')
-                // function-arguments-wrap
 
                 stackItem.getElementsByClassName('function-arguments-wrap')[0].classList.toggle('hidden')
             });
@@ -266,8 +264,8 @@ class="copy-clipboard"
             arguments?.addEventListener('select', function (e) {
                 e.stopPropagation()
                 e.stopImmediatePropagation()
-
             })
+
             arguments?.addEventListener('click', function (e) {
                 e.stopPropagation()
                 // stop click event on selecting text