Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NoKeyInPayloadException for usage in case "No key or invalid key type" #62

Open
vjik opened this issue Mar 22, 2023 · 3 comments
Open

Update NoKeyInPayloadException for usage in case "No key or invalid key type" #62

vjik opened this issue Mar 22, 2023 · 3 comments
Milestone
1.0.0

Comments

@vjik
Copy link
Member

vjik commented Mar 22, 2023

Now NoKeyInPayloadException throws when key not exist or key of invalid type.
@s1lver s1lver closed this as completed Apr 3, 2023
@vjik
Copy link
Member Author

vjik commented Apr 4, 2023

Why close it? Issue is not resolved.

@vjik vjik reopened this Apr 4, 2023
@s1lver
Copy link
Member

s1lver commented Apr 4, 2023

Why close it? Issue is not resolved.

Hm, maybe I didn't understand what you mean

@vjik
Copy link
Member Author

vjik commented Apr 4, 2023

Hm, maybe I didn't understand what you mean

NoKeyInPayloadException can be throw when key exist in payload, but have invalid type. For example:

https://github.com/yiisoft/yii-queue-amqp/blob/29c2b4ea82e018c77417b130a0021a6ea27e91f6/src/MessageSerializer.php#L42-L45

@s1lver s1lver added this to the 1.0.0 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@vjik @s1lver