Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance queue and validator collectors #169

Open
xepozz opened this issue Jul 31, 2022 · 1 comment
Open

Enhance queue and validator collectors #169

xepozz opened this issue Jul 31, 2022 · 1 comment
Assignees
Labels
status:ready for adoption Feel free to implement this issue. type:enhancement Enhancement

Comments

@xepozz
Copy link
Member

xepozz commented Jul 31, 2022

Here was added an integration with yii-queue.

I think it would be useful to pass a class that called any "queue" methods, such as push(), status() and the rest.
Sometimes user may know which class pushed message to a queue, even if the one may be pushed from a few handlers.
I mean the same functionality as in EventDispatcherInterfaceProxy:

public function dispatch(object $event): object
{
    [$callStack] = debug_backtrace();

    $this->collector->collect($event, $callStack['file'] . ':' . $callStack['line']);

    return $this->dispatcher->dispatch($event);
}

Also the same thing is needed for the ValidatorCollector

@samdark
Copy link
Member

samdark commented Aug 1, 2022

Yes, that's useful for tracing event origin.

@samdark samdark added type:enhancement Enhancement status:ready for adoption Feel free to implement this issue. labels Aug 1, 2022
@rustamwin rustamwin self-assigned this Nov 24, 2022
@xepozz xepozz transferred this issue from yiisoft/yii-debug May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready for adoption Feel free to implement this issue. type:enhancement Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants