Move unused arguments to query parameters when generating a URL

[vjik]

UrlGeneratorInterface methods for URL generation have parameters: $arguments and $queryParameters. Currently, arguments used in route path (/route/{id}), and query parameters added to query (?id=7).

This behavior causes difficulties in use. For example, when in route we need to move query parameter to path:

// Before, result: /blog/post?id=42
$route = Route::get('/blog/post')->name('post')
$generator->generate('post', [], ['id' => 42])

// After, result: blog/post/42
$route = Route::get('/blog/post/{id}')->name('post')
$generator->generate('post', ['id' => 42], [])

In this case changed only route, code for generation should keep as is, but currently we need to change both route and generation code. It's bad.

I suggest to move unused arguments to query parameters, if not setted query parameter with such name:

// Before, result: /blog/post?id=42
$route = Route::get('/blog/post')->name('post')
$generator->generate('post', ['id' => 42], [])

// After, result: blog/post/42
$route = Route::get('/blog/post/{id}')->name('post')
$generator->generate('post', ['id' => 42], [])

Not need change generation code. We change only route configuration.

[samdark]

Good idea. Let's do it.