Use greedy search "controller(s)" in controller name extractor #120
+42
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vjik
commented
Jun 19, 2024
vjik
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ✔️ |
| Fix #64 |
…controller name extractor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #120 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 88 90 +2
===========================================
Files 9 9
Lines 256 257 +1
===========================================
+ Hits 256 257 +1 ☔ View full report in Codecov by Sentry. |
samdark
approved these changes
Jun 19, 2024
Co-authored-by: Alexander Makarov <[email protected]>
vjik
commented
Jun 19, 2024
vjik
commented
Jun 19, 2024
Done |
samdark
approved these changes
Jun 22, 2024
Co-authored-by: Alexander Makarov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.