New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated `jax.core.canonicalize_shape` call in `_types.py` #3

Open

chungmin99 opened this issue Aug 16, 2024 · 0 comments

chungmin99 commented Aug 16, 2024

Hi! This is super cool, thank you for making it -- I just ran examples/single_images.py, and stuff ran pretty smoothly :-)

I noticed that in _types.py you're using jax.core.canonicalize_shape (

jaxsplat/jaxsplat/_types.py

Line 15 in 502a10d

self.shape = canonicalize_shape(shape)

), but this has been deprecated/removed in recent jax versions (https://github.com/google/jax/blob/60cc0411330d5c3652fe5eb8455408e7abf65912/CHANGELOG.md?plain=1#L80).

Is the canonicalize_shape call necessary? If so, maybe a note pinning the jax version could be helpful.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment