Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregister SipListenerEvent #3

Open
morvader opened this issue Dec 11, 2014 · 1 comment
Open

Unregister SipListenerEvent #3

morvader opened this issue Dec 11, 2014 · 1 comment

Comments

@morvader
Copy link

In RegisterHandler.java file, at successResponseReceived method, register successfull event is raised even when you are actually unregistering.

At then end of the method, the [ !"0".equals(expires) ] check does not have any effect, so event is raised anyway

if (sipListener != null) {
     sipListener.registerSuccessful(sipResponse);
}

Thaks for such a great effort!

@morvader morvader changed the title Unregister SipListernEvent Unregister SipListenerEvent Dec 11, 2014
@ymartineau
Copy link
Owner

maybe this expires != 0 test has no effect because expires is not a parameter in contact header but a header of its own. But you're right, it should probably be fixed (get expires parameter in contact header and if it's not found try to get Expires header and depending on this value, notify or not sipListener)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants