Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node name doesn't get updated when undoing in IDA #22

Open
Azertinv opened this issue Jan 17, 2025 · 2 comments
Open

Node name doesn't get updated when undoing in IDA #22

Azertinv opened this issue Jan 17, 2025 · 2 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Azertinv
Copy link

When you rename a a function the graph gets updated but not when you undo that renaming in IDA.
I think you need to handle ev_ending_undo and check if the undo was to rename a node.

@yoavst
Copy link
Owner

yoavst commented Jan 17, 2025

Thanks for reporting :)
I'll work on it soon

@yoavst yoavst added the bug Something isn't working label Jan 18, 2025
@yoavst yoavst self-assigned this Jan 18, 2025
@yoavst
Copy link
Owner

yoavst commented Jan 18, 2025

I'm not sure what should I do in this case.
ev_ending_undo just say a MakeName event was redo/undo, but without context.
ev_replaying_undo has param for const undo_records_t * but I can't find any information about this object

I can stream all renames the IDB has on every undo/redo operation, but that seems inefficient.

@yoavst yoavst added the help wanted Extra attention is needed label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants