Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to Chromatic build on PRs #51

Closed
PatrickDeVries opened this issue Feb 8, 2023 · 1 comment · Fixed by #54
Closed

Add link to Chromatic build on PRs #51

PatrickDeVries opened this issue Feb 8, 2023 · 1 comment · Fixed by #54
Assignees
Labels
tooling Improvements or additions to tooling

Comments

@PatrickDeVries
Copy link
Member

This may require updating CI to use the Chromatic GitHub Action.
Adding a build link to the PR is not yet supported directly but the build link is output by the Chromatic GitHub action and could then be added as a normal comment.
Only the latest build should be linked, so the comment should be updated when it already exists rather than adding a new one.

@PatrickDeVries PatrickDeVries added the tooling Improvements or additions to tooling label Feb 8, 2023
@PatrickDeVries PatrickDeVries self-assigned this Feb 9, 2023
@PatrickDeVries
Copy link
Member Author

Because actions get a read-only token on PRs form forks, this cannot be done for PRs from forks without security risks / a separate server with a PAT, so we cannot do this. Instead, we can just build it in main on merge and output the build info to the action output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Improvements or additions to tooling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant