Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the working of a spell #11

Open
xeon-zolt opened this issue May 19, 2018 · 3 comments
Open

change the working of a spell #11

xeon-zolt opened this issue May 19, 2018 · 3 comments

Comments

@xeon-zolt
Copy link
Member

just a suggestion to change the working of spell avada-kedavra from rm to pkill
or if there is another killing spell ( not a harry potter fan so I don't know much ) I would like to create a pull to add it (this will help me learn js)

@gabru-md
Copy link
Member

gabru-md commented Oct 8, 2018

we can maybe gather people to get started into this project now since we have hacktober going on.
Therefore I am adding hacktoberfest label to this repository as well

@jacquesdev
Copy link

rm and pkill are (to my knowledge not related, remove/delete a file, vs stopping a process), so just wanted to check if this issue is required in general?

@gabru-md
Copy link
Member

this is a fun repository, you can add your suggestions anytime.
yes rm and pkill are not related to each other closely, but we need that they are closely related to the spell that they are bonded to.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants