Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version without bootstrap #28

Closed
ayonix opened this issue Oct 22, 2014 · 9 comments
Closed

Version without bootstrap #28

ayonix opened this issue Oct 22, 2014 · 9 comments

Comments

@ayonix
Copy link

ayonix commented Oct 22, 2014

Hey, I don't really want to import bootstrap as well in my application.
Would it be possible to make a version without bootstrap as dependency?

@yogiben
Copy link
Owner

yogiben commented Oct 22, 2014

Nope. The frontend is a bootstrap theme.

@yogiben yogiben closed this as completed Oct 22, 2014
@RobertLowe
Copy link
Contributor

@yogiben This is important because if you're using other frameworks like meteor + polymer you can't use Meteor admin for instance. The admin should be agnostic, or work like cfs where there is a useBootstrap or useSemantic option.

Cheers

@yogiben
Copy link
Owner

yogiben commented Jan 23, 2015

The difference between cfs and admin is that admin requires a much more complex UI. I wanted to give users something beautiful so I used LTE Admin which is based on bootstrap.

I'm happy to accept a PR.

@richarddewit
Copy link

Maybe add an option in the config to "lazyload" Bootstrap and/or FontAwesome.

To give you an impression:

Config

@AdminConfig = 
  lazyLoad: {
    bootstrap: true
    fontawesome: false
  }

/lib/both/router.coffee

@AdminController = RouteController.extend
  onBeforeAction: ->

    # Some stuff omitted..

    if AdminConfig.lazyLoad.bootstrap
      $("<link/>", {
        rel: "stylesheet"
        type: "text/css"
        href: "//maxcdn.bootstrapcdn.com/bootstrap/3.3.4/css/bootstrap.min.css"
      }).appendTo('head')

    if AdminConfig.lazyLoad.fontawesome
      $("<link/>", {
        rel: "stylesheet"
        type: "text/css"
        href: "//maxcdn.bootstrapcdn.com/font-awesome/4.3.0/css/font-awesome.min.css"
      }).appendTo('head')

    @next()

I just wrote this from the top of my head, but this is how that PR could look like.

See this and this for more info.

@richarddewit
Copy link

Made a PR #183

@sunstorymvp
Copy link

any news here? can't use this package because bootstrap styles leaks to the app...

@mpowaga
Copy link
Collaborator

mpowaga commented Jul 7, 2015

The new version loads meteor-admin stylesheets lazily. It doesn't work for bootstrap files but we are working on this.

@ghost
Copy link

ghost commented Aug 8, 2015

has any progress been made on this?

@levino
Copy link

levino commented May 25, 2016

Old topic. Still no solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants