Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API isn't thread-safe #27

Open
stefanor opened this issue Mar 14, 2019 · 0 comments
Open

API isn't thread-safe #27

stefanor opened this issue Mar 14, 2019 · 0 comments
Assignees
Labels

Comments

@stefanor
Copy link
Contributor

The HealthCheck objects store state on themselves, which you need to check in subsequent is_ok calls.

Every run of the run() method first clears _ok and _details before populating them, 1 item at a time.

If there's a global HealthCheck object, shared between threads (sbbe has an example of such a thing), then is_ok could show you the empty status, at the start of another thread's run.

@yola/service-engineering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants