Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect file system from mid-deploy failures #114

Open
beck opened this issue Feb 11, 2015 · 5 comments
Open

Protect file system from mid-deploy failures #114

beck opened this issue Feb 11, 2015 · 5 comments

Comments

@beck
Copy link
Contributor

beck commented Feb 11, 2015

@stefanor has plans for this:

stage all templating into a directory tree inside the deployed app. And then just copy the whole directory tree to /etc/ when deployed

@beck
Copy link
Contributor Author

beck commented Feb 11, 2015

Question, why not:

Keep the templating stage inside the app dir, symlink vhosts and includes (or any other filesystem updates) to said templating stage via the deployed dir's live symlink. That way all file system updates happen with a single swing.

@thomasw
Copy link
Contributor

thomasw commented Feb 11, 2015

What @stefanor described was actually how I thought it worked now.

@stefanor
Copy link
Contributor

@beck: That is probably even better, yes. But it won't work for everything. Upstart monitors job file changes with inotify, and won't detect the symlink swap. Other things may, too.

@beck
Copy link
Contributor Author

beck commented Feb 11, 2015

won't detect the symlink swap

When a symlink is touched do the monitors fire? If yes, then content changes could happen with a single swing followed by a touch of all incoming symlinks.

This may be a bit of an over-engineered solution for our needs, I think your approach would be good enough. I'm just experiencing some PTSD when I had to use WordPress and deploying an update made everything explode.

@stefanor
Copy link
Contributor

No, upstart explicitly ignores symbolic links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants