Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dictionary-level deinflection tags incorrectly assigned to many unrelated terms in search results #1509

Open
stephenmk opened this issue Oct 19, 2024 · 0 comments
Labels
kind/bug The issue or PR is regarding a bug

Comments

@stephenmk
Copy link

Test Dictionary 1

This dictionary works correctly and as expected.

test_dictionary_1.zip

[
    ["ホシ", "ホシ", "", "", 0, ["See: 星", ["",  ["redirected from ホシ"]]], 1, ""],
    ["干し", "ほし", "", "", 0, ["Glossary for 干し"], 2, ""],
    ["乾し", "ほし", "", "", 0, ["Glossary for 乾し"], 3, ""],
    ["", "ほし", "", "", 0, ["Glossary for 干"], 4, ""],
    ["", "ほし", "", "", 0, ["Glossary for 乾"], 5, ""],
    ["", "せい", "", "", 0, ["Glossary for 星"], 6, ""]
]

The image below shows the search results for ホシ. The deinflection tag ("redirected from ホシ") correctly appears on the term for 星.

Yomitan search results for ホシ

test_1

Test Dictionary 2

This dictionary is identical to the one above, except the reading for 星 has been changed from せい to ほし.

test_dictionary_2.zip

[
    ["ホシ", "ホシ", "", "", 0, ["See: 星", ["",  ["redirected from ホシ"]]], 1, ""],
    ["干し", "ほし", "", "", 0, ["Glossary for 干し"], 2, ""],
    ["乾し", "ほし", "", "", 0, ["Glossary for 乾し"], 3, ""],
    ["", "ほし", "", "", 0, ["Glossary for 干"], 4, ""],
    ["", "ほし", "", "", 0, ["Glossary for 乾"], 5, ""],
    ["", "ほし", "", "", 0, ["Glossary for 星"], 6, ""]
]

The image below shows the search results for ホシ and ほし. In both queries, the deinflection tag ("redirected from ホシ") incorrectly appears on all of the other terms.

Yomitan search results for ホシ

test_2

Yomitan search results for ほし

test_3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

No branches or pull requests

1 participant