Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright tests are flaky #1540

Open
jamesmaa opened this issue Oct 28, 2024 · 1 comment
Open

Playwright tests are flaky #1540

jamesmaa opened this issue Oct 28, 2024 · 1 comment
Labels
kind/bug The issue or PR is regarding a bug

Comments

@jamesmaa
Copy link
Collaborator

This seems to have been happening occasionally before the recommended settings PR. The earliest instance I could find was from #1476's run

https://github.com/yomidevs/yomitan/actions/runs/11265422024/job/31327215970

image

Neighboring commits on master
image

@jamesmaa jamesmaa added the kind/bug The issue or PR is regarding a bug label Oct 28, 2024
@jamesmaa
Copy link
Collaborator Author

Update: after some observation it is observed that the action of trying to load json in the playwright tests causes other file load operations to fail. For some reason this issue is fixed when tracing is turned enabled.

Our current hypothesis is that the performance impact of enabling tracing causes more spacing between multiple file load operations, which allows some hidden shared resource to not enter a pathological state. However, we're not prioritizing investigating this further at this point.

Our current remediation is to avoid too many file loads in our playwright tests. For the recommended settings PR, we will move the logic of loading the json outside the initialization path and make it lazy load on interact, thereby removing it from our existing playwright coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

No branches or pull requests

1 participant