-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
furigana-plain versions of handlebars #1596
Comments
I got tired of not having this feature, so I started working on a fork to implement it. I'm at a bit of a crossroads with the implementation now though. I have the option to either implement it with my original idea of having a setting to change the encoding, or I can implement it using the handles suggested here. I haven't looked into how the code base handles settings already, so I have no idea how easy or hard my idea will be to implement, but the idea of just making separate handles seems like it would be easy enough to add. The main reservation I have with using handles over a separate setting is I'd imagine having a (for example) For now I'll just make it so the fork I'm working on defaults to the plain encoding. |
I looked at this a bit back and the whole furigana part of the handlebars should probably be rewritten in js. It's a mess. |
Ah, I see. The bit that actually handles the encoding seemed fine to me,
but I am also not a JS dev and I hardly ever program anymore so I'm not
exactly the most discerning. For the time being I'll just publish my fork
after I verify it works. That way the people who really want it will have
access to it at least
2025年1月16日(木) 午後9:05 Kuuuube ***@***.***>:
… I looked at this a bit back and the whole furigana part of the handlebars
should probably be rewritten in js. It's a mess.
—
Reply to this email directly, view it on GitHub
<#1596 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFR557FHOMZNYEVOL7FVGIL2LCFTDAVCNFSM6AAAAABSJSHZG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJXGQ2DEOJTHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Also interested in this, sentence-furigana is difficult to edit. I believe I'm using AJT Japanese for the functionality currently. |
I've gotten pretty far in the implementation to add this feature, but I
ended up completely breaking breaking everything with the modifications
I've made. Once I manage to un-break it, it shouldn't take too long to get
it ready for review though. (As kube said, it actually is pretty messy,
ctrl+f just allowed me to skip all the bad parts before)
I don't currently have an ETA for when that might be though. Between how
confusing the existing code base is and having to deal with full time uni
and part time work, I just don't have much time left over to work on this
project. Hopefully I'll be able to get it done soon though
2025年2月15日(土) 午後8:58 elemn ***@***.***>:
… Also interested in this, sentence-furigana is difficult to edit. I believe
I'm using AJT Japanese for the functionality currently.
—
Reply to this email directly, view it on GitHub
<#1596 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFR557ECBAFLTXXPL6SMU6L2QALHVAVCNFSM6AAAAABSJSHZG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGI2DMMJXGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: elemn]*elemn* left a comment (yomidevs/yomitan#1596)
<#1596 (comment)>
Also interested in this, sentence-furigana is difficult to edit. I believe
I'm using AJT Japanese for the functionality currently.
—
Reply to this email directly, view it on GitHub
<#1596 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFR557ECBAFLTXXPL6SMU6L2QALHVAVCNFSM6AAAAABSJSHZG6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRRGI2DMMJXGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
There are a couple Japanese card types right now that use a Sentence Furigana field that consists of the sentence with a bolded target word and Anki-style bracketed furigana (eg
今[いま]
). Currently, those cards rely on Anki add-ons to accomplish this, but it would be nice if there were a way to generate this content natively from Yomitan, especially for users on devices that don't support add-ons.I'm proposing the following handlebars:
{sentence-furigana-plain}
{cloze-prefix-furigana-plain}
{cloze-body-furigana-plain}
{cloze-suffix-furigana-plain}
They would function the same as their current cloze handlebars equivalent, but with added Anki-style furigana.
The text was updated successfully, but these errors were encountered: