Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan on touch release is incompatible with pointer api #1779

Open
Kuuuube opened this issue Jan 26, 2025 · 0 comments
Open

Scan on touch release is incompatible with pointer api #1779

Kuuuube opened this issue Jan 26, 2025 · 0 comments
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/bug The issue or PR is regarding a bug regression This issue or PR is related to a regression

Comments

@Kuuuube
Copy link
Member

Kuuuube commented Jan 26, 2025

Regression caused by #1585

The pointerup event is often hijacked by the browser itself and will not fire. The pointercancel event will be triggered if the touch point is moved before the touch is released and there will be no pointerup event in any case where the browser decides to use the event instead. For example: scrolling, zooming, panning, etc. Essentially any movement of the touch point. This makes it act almost identical to Scan on touch tap.

This is easily fixed on pages controlled by whoever desires to receive the pointerup and prevent the browser from messing with it by using the touch-action css property https://developer.mozilla.org/en-US/docs/Web/CSS/touch-action.

But since Yomitan runs on any page a user opens, this is obviously not a solution. Currently, I don't see any way to fix this and restore the old behavior of Scan on touch release (without reverting #1585 which is probably undesirable).

@Kuuuube Kuuuube added area/ui-ux The issue or PR is related to UI/UX/Design kind/bug The issue or PR is regarding a bug regression This issue or PR is related to a regression labels Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/bug The issue or PR is regarding a bug regression This issue or PR is related to a regression
Projects
None yet
Development

No branches or pull requests

1 participant