Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text formatting alters when changing fonts #1805

Closed
40elyK opened this issue Feb 6, 2025 · 1 comment
Closed

Text formatting alters when changing fonts #1805

40elyK opened this issue Feb 6, 2025 · 1 comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/bug The issue or PR is regarding a bug triage/wontfix The issue or PR will not be worked on

Comments

@40elyK
Copy link

40elyK commented Feb 6, 2025

Description
Whenever changing the font of Yomitan, the formatting of the word being defined changes, as fonts like Noto Sans/Serif push the dotted underline of a kanji/hanzi below the tags and pushing the reading up. Also, when changing fonts, the preview display differs from the actual display when on websites.

Normal:

Image

Custom Font (Noto Serif JP):

[ON EXTERNAL SITES]

Image

[IN YOMITAN PREVIEW]

Image

[THIS HOLDS TRUE FOR NOTO SANS JP]

Custom Font (Yu Mincho [this one works, as well as Meiryo UI)

Image

Custom Font (Meiryo [ik yomitan uses it already, but putting it in as a custom font breaks formatting])

Image

These are all the fonts that I tested, and I'm confident more work and don't work, but I figured it was worth going over. Specially how some custom fonts don't seem to work outside of the Yomitan preview.

Browser version
Firefox 135.0

Yomitan version
25.1.5.0

Exported settings file
(If you think it might be relevant, create a settings export file using the Export Settings button on the settings page and attach it to this issue.)

@40elyK 40elyK added the kind/bug The issue or PR is regarding a bug label Feb 6, 2025
@Kuuuube
Copy link
Member

Kuuuube commented Feb 8, 2025

You likely need to fix this yourself with custom css. It doesn't seem reasonable for Yomitan to implement some way of trying to figure out where to put this line with all the variations in fonts.

You can access custom css in settings by enabling Advanced and it will be under Appearance as Configure custom CSS....

@Kuuuube Kuuuube closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2025
@Kuuuube Kuuuube added triage/wontfix The issue or PR will not be worked on area/ui-ux The issue or PR is related to UI/UX/Design labels Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/bug The issue or PR is regarding a bug triage/wontfix The issue or PR will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants