Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Week 2 Assignment] Yelp #1

Open
yonpols opened this issue Nov 3, 2015 · 1 comment
Open

[Week 2 Assignment] Yelp #1

yonpols opened this issue Nov 3, 2015 · 1 comment

Comments

@yonpols
Copy link
Member

yonpols commented Nov 3, 2015

Please review my app /cc @codepathreview

@nickai
Copy link
Contributor

nickai commented Nov 9, 2015

👍 Excellent work Juan! The primary challenge of this homework was to learn how to use UITableView to manage a complex form, establish communication between view controllers, and apply the correct Auto Layout constraints.

A few notes after checking out the code:

  • Really like to see all the extras you added, including using CoreLocation to get the user's actual location!
  • For the business cell, nice work encapsulating the properties into the private class extension.
  • Nice work specifying the Auto Layout constraints.
  • Nice work implementing the filters view controller. See this popular form library for an alternative to implementing forms manually.
  • Nice work connecting the view controllers via the custom filter delegate. This is a popular pattern for handling events between view controllers.

This was a challenging assignment, congrats on completing it successfully! We have provided a detailed Project 2 Feedback Guide which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of iOS development is learning the correct patterns and conventions.

If you have any particular questions about the assignment or the feedback, feel free to reply here or email us at [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants