Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use menhir-based parser instead of camlp4o #16

Closed
seliopou opened this issue Dec 5, 2015 · 5 comments
Closed

Use menhir-based parser instead of camlp4o #16

seliopou opened this issue Dec 5, 2015 · 5 comments
Milestone

Comments

@seliopou
Copy link
Collaborator

seliopou commented Dec 5, 2015

The library uses camlp4o to parse locale definitions, which is a hinderance to both adoption (see tategakibunko/jingoo#19) as well as future maintenance. The parser should be ported to menhir or some such other parser library to break the dependency with camlp4o.

@rgrinberg
Copy link
Collaborator

+1, we should absolutely get rid of camlp4 where possible.

@michipili definitely a milestone before 1.0 IMO

@seliopou
Copy link
Collaborator Author

seliopou commented Dec 5, 2015

The grammar that the parser implements is documented here.

It took forever to find it. Enterprise software is terrifying.

@foretspaisibles foretspaisibles modified the milestone: backlog Dec 5, 2015
@foretspaisibles
Copy link
Collaborator

@rgrinberg Agreed! #12.

@rgrinberg
Copy link
Collaborator

I have a branch (on top of #22) that replaces the camlp4 lexer with with the same lexer but without the syntax extension. It would still be nice to have a proper menhir based parser, but i think that should be enough to solve this problem for the medium term.

@rgrinberg
Copy link
Collaborator

We aren't using camlp4 anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants