Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect focus upgrade being applied #83

Open
piedragon12 opened this issue Sep 21, 2022 · 12 comments
Open

Incorrect focus upgrade being applied #83

piedragon12 opened this issue Sep 21, 2022 · 12 comments

Comments

@piedragon12
Copy link

When ever anyone in the server i run Tries to upgrade the dark matter focus with sanity, diffusion or any other tainted magic specific upgrades it just adds on the nuggets upgrade i have attached my mod list i have no idea what is causing this
list.txt

@piedragon12
Copy link
Author

actually after further investigation its any specific tainted magic upgrade

@yorkeJohn
Copy link
Owner

yorkeJohn commented Sep 21, 2022

Thank you for your bug report.

Please verify that the focus upgrade IDs for the Thaumcraft add-ons you have installed are properly configured such that no IDs overlap. Tainted Magic’s upgrade IDs are configurable in the mod’s config file. It is possible that another mod’s focus upgrades are using the same IDs as Tainted Magic’s default configuration, causing the wrong upgrade to be applied.

It would also be helpful to know which mod is adding the focus upgrade which you have reported is getting applied.

Cheers

@yorkeJohn yorkeJohn changed the title Dark matter Wand focus upgrades Incorrect focus upgrade being applied Sep 21, 2022
@piedragon12
Copy link
Author

it is Thaumic Horizons that adds in the upgrade that it switches them to and after changing all the values to ones that aren't being used it wont allow me to apply any of tainted magics specific upgrades they appear but are otherwise nonfunctional

@piedragon12
Copy link
Author

would you happen to know off hand if any other Ids work or if they need to be in any specific order as I've cycled through most of them and it just seems to outright disable the ability to apply any of them now

@yorkeJohn yorkeJohn added the bug label Oct 5, 2022
@yorkeJohn
Copy link
Owner

Upon inspection this looks like it could be a code bug with how the focus upgrades are initialized. I will look into this more.

@yorkeJohn
Copy link
Owner

I have been trying to reproduce this issue and I can't seem to get it to happen. Does this issue happen in your modpack when running singleplayer as well? Or only when running multiplayer?

@piedragon12
Copy link
Author

after testing for a few days the behavior remains regardless of what I do in both single and multiplayer

@ianlavr
Copy link

ianlavr commented Jan 21, 2023

still having this issue

upgrading the dark matter focus with sanity turned that upgrade into nuggets
along with not causing warp it now also shoots out a diffusion cloud instead of a dark matter ball and seems to cause wither
i did not upgrade it with diffusion or corrosion yet only sanity
it seems like the upgrade nuggets functions as every tainted magic added upgrade on a focus

hopefully this gets fixed some day

@yorkeJohn
Copy link
Owner

Unfortunately as far as I can tell, this is an issue with Thaumic Horizons, which is not open source, so I really can't do much to fix this. Possible solutions include removing Thaumic Horizons from your modpack, or contacting the TC mod author for assistance.

@yorkeJohn
Copy link
Owner

The only other thing that could help would be if you could post your startup log so that I can see if there is any error being reported when loading in the focus upgrades.

@yorkeJohn yorkeJohn reopened this Feb 10, 2023
@ianlavr
Copy link

ianlavr commented Feb 27, 2023

latest.log

Hopefully this is the thing youre looking for

Also after some testing it seems that this isnt an issue related solely to thaumic horizons
With the latest versions of TC, TH, TM and Gadomancy(for convenience) and nothing else. The Dark Matter focus still gets the correct upgrade.
It seems that another mod is messing something up along with TH. I wonder how many possible focus upgrade ids are there?
2023-02-27_23 13 21

@ianlavr
Copy link

ianlavr commented Mar 1, 2023

Changing the focus ids to ridiculously high fixed this (atleast for me). Not sure on why I havent done that before

Edit: Nope it didnt. In a creative world it worked but in my survival world it still just turns into nuggets. HOWEVER this seems to be only a graphical glitch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants