Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce CI test time by optimizing task execution #789

Closed
hackerwins opened this issue Feb 9, 2024 · 4 comments · Fixed by #988
Closed

Reduce CI test time by optimizing task execution #789

hackerwins opened this issue Feb 9, 2024 · 4 comments · Fixed by #988
Assignees
@binary-ho
Labels
enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers

Comments

@hackerwins
Copy link
Member

Description:

Currently, when a PR is opened, the CI process runs various tasks including Build and Integration Test, Benchmark, Sharding Test, Releasing Charts, and Publishing Docker Images.

  • Build and Integration Test: 8 mins
  • Benchmark: 5 mins
  • Sharding Test: 3 mins
  • Release Charts: 10 secs
  • Publish Docker Images: 7 mins

The integration Test takes to complete these tasks is 8 minutes.

To ensure that the testing process finishes within 10 minutes, it is necessary to optimize the tasks. Specifically, we should consider the following changes:

  • Rename "Sharding Test" to "Complex Test" to better reflect its purpose.
  • Move the "Tree Concurrency Test" from the Integration Test to the Complex Test.

These changes will help reduce the total test time and ensure that the testing process is completed within the required 10 minutes.

Why:

Currently, the integration test with the Tree Concurrency Test takes up most of the 8-minute test time, causing delays in the CI process. By optimizing the task execution and reducing the test time, we can improve the efficiency of our CI pipeline and ensure timely feedback on pull requests.
@hackerwins hackerwins added the enhancement 🌟 New feature or request label Feb 9, 2024
@hackerwins hackerwins added the good first issue 🐤 Good for newcomers label Feb 9, 2024
@hackerwins hackerwins mentioned this issue Feb 9, 2024
Closed
2 tasks
highcloud100 added a commit that referenced this issue Feb 12, 2024
@highcloud100
Fix snapshot just return the latestVectorClock not SVM
f6d9a58 
1. Now snapshot save latest vector clock not SVM.
2. Clients build their own SVM using the latest VectorClock in snapshots.
- So client's SVM is not latest state, it doesn't know peer's vector clock. It need more check
- This is due to the overhead of storing and transferring SVMs. #789
@krapie
Copy link
Member

krapie commented Mar 5, 2024 •
edited
Loading

I really want this to be optimized. Integration test alone takes almost 4 mins to execute in my local machine(Mac M1 Pro).
Feeling stuck every time I run tests :(

Screenshot 2024-03-05 at 7 15 19 PM

@binary-ho
Copy link
Contributor

binary-ho commented Aug 11, 2024 •
edited
Loading

I'm interested in this. can I try this?

@sejongk
Copy link
Contributor

sejongk commented Aug 11, 2024

I'm interested in this. can I try this?

@binary-ho Sure. If you have any questions, feel free to ask.

@sejongk sejongk moved this from Backlog to In progress in Yorkie Project - 2024 Aug 11, 2024
@hackerwins
Copy link
Member Author

Related to #954

@binary-ho binary-ho mentioned this issue Sep 7, 2024
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in Yorkie Project - 2024 Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binary-ho binary-ho

Labels
enhancement 🌟 New feature or request good first issue 🐤 Good for newcomers
Projects
Yorkie Project - 2024
Status: Done
Yorkie Project
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reduce CI test time by optimizing task execution yorkie-team/yorkie
4 participants
@hackerwins @sejongk @krapie @binary-ho