Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query parameter support #18

Open
Antman261 opened this issue Aug 4, 2021 · 0 comments
Open

Query parameter support #18

Antman261 opened this issue Aug 4, 2021 · 0 comments

Comments

@Antman261
Copy link
Contributor

Currently there doesn't appear to be any support for query parameters, i.e. /some-resource/:id/sub-collection?filter=some-facet

Query parameters are different from params because they're optional and often used in GET requests to filter the result in some way.

At present, the library actually prevents query parameter usage entirely, as the client will throw a type error if you try to add one.

A simple solution in the interim may be to add a queryParam object to the request info options object. This could be typed as URLSearchParams so we leverage existing browser implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant