Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Exception Classes are not PHP5 compatible #122

Open
damanic opened this issue Feb 24, 2022 · 2 comments
Open

Exception Classes are not PHP5 compatible #122

damanic opened this issue Feb 24, 2022 · 2 comments

Comments

@damanic
Copy link

damanic commented Feb 24, 2022

Class constant visibility is only allowed since PHP 7.1

Example in LEConnectorException

	public const NONEWNONCEEXCEPTION 			= 0x11;
	public const ACCOUNTDEACTIVATEDEXCEPTION 	= 0x12;
	public const METHODNOTSUPPORTEDEXCEPTION 	= 0x13;
	public const CURLERROREXCEPTION 			= 0x14;
	public const INVALIDRESPONSEEXCEPTION 		= 0x15;
@TheRealSimpleSimon
Copy link

Considering that PHP8 is current, I doubt anyone will have time to maintain support for PHP5.

@damanic
Copy link
Author

damanic commented May 2, 2022

@TheRealSimpleSimon
Considering the guidance on your repo states The minimum required PHP version is 5.2.0. , the pull request is valid.

Did anyone actually need to introduce constant visibility? If you are keeping the change you need to update your minimum required PHP version to 7.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants