Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to update this library to swift 4.0? #177

Open
dileep017 opened this issue Jan 24, 2018 · 15 comments
Open

Any plans to update this library to swift 4.0? #177

dileep017 opened this issue Jan 24, 2018 · 15 comments

Comments

@dileep017
Copy link

Are there any plans to update this library to Swift 4.0?

@lolgear
Copy link
Collaborator

lolgear commented Jan 24, 2018

@dileep017 what do you mean?
It is an objective-c library with support even iOS 6. ( I hope so )

@dileep017
Copy link
Author

I meant are you planning to write a swift code for this library??

@lolgear
Copy link
Collaborator

lolgear commented Jan 25, 2018

@dileep017
It is a pure objective-c library.
It could be used in projects with swift 4, I suppose.

@lolgear
Copy link
Collaborator

lolgear commented Jan 26, 2018

@dileep017
solved?

@dileep017
Copy link
Author

@lolgear i was talking about native Swift library. Yes you can bridge the objective c library and use it in swift.But i haven`t seen a single swift written library supports SH,RS and ES algorithms.
If you get what i mean, i would like to contribute to write this library in swift with your inputs.

@lolgear
Copy link
Collaborator

lolgear commented Jan 26, 2018

@dileep017
well, interesting.
How do you want to organize development of this library?

Should it be a part of current JWT library?
Should it be stored somewhere else? ( In this scenario I suggest to put it into jwt group )

@dileep017
Copy link
Author

Yes i would like to ask about the same, how could we organize the development of this library?
Do i get any help any more hands or are you expecting me to work alone?
And also i need to know a basic stuff like how to create the source code as library and convert it into a framework and pod.
Yes it can be a part of current jwt library and we can store it in jwt group as you said.

@lolgear
Copy link
Collaborator

lolgear commented Jan 27, 2018

@dileep017 I will think about all stuff at end of this week.

let me conclude questions about it:

  1. How to organize development?
  2. Alone or pair/team?
  3. Distribution stuff for swift. ( Package manager, cocoa pods, Carthage )
  4. Part of JWT or another project?

@dileep017
Copy link
Author

@lolgear Sure will wait for your update.

@dileep017
Copy link
Author

dileep017 commented Feb 9, 2018 via email

@lolgear
Copy link
Collaborator

lolgear commented Feb 13, 2018

@dileep017 Hi!
I wait for a reply from inner developer of JWT.

Recently I asked him about opportunity to move this repo to group ( organization ) that I mentioned above.
It is a corner stone for now, because I don't have permissions to extend development team here.

  1. How to organize development?
  2. Alone or pair/team?
  3. Distribution stuff for swift. ( Package manager, cocoa pods, Carthage )
  4. Part of JWT or another project?

How to organize development?
It depends on reply from JWT developer.
It would be nice to move this repo to another group ( organization/team ) and to continue development. In this case it would be simple to start.

Alone or pair/team?
I could help you, but all stuff should be rewritten from sketch ( because this library has three big problems - legacy, backward API compatibility, old iOS version support ).
Even tests should be rewritten.
However, I have some thoughts in making this simple.

Distribution stuff for swift. ( Package manager, cocoa pods, Carthage )
Do not know about Carthage, but, of course, it would be nice to support it.
CocoaPods and Package manager should be.
Not sure, but I think that Package manager is a nice replacement for both.

Part of JWT or another project?
Preferably not. Again, it would be nice to host it in the group that I mentioned above.

Some other thoughts.
version 3.0, I think it would be the last version. Legacy is unbearable now and should be rewritten.

@dileep017
Copy link
Author

@lolgear Okay sounds like a plan. But I am happy to write it alone,but i just need a guidance regards legacy,backward API Compatability and old iOS version support.Along with the distribution stuff.

@lolgear
Copy link
Collaborator

lolgear commented Feb 16, 2018

@dileep017
Ok, first of all, try to rewrite algorithm part ( HS only ) in Swift manner ( with further easy-to-extend to RS and possibly ES ).
As I remember, it doesn't use some legacy of apple OS part.
It will be JWA module.
and do not care about distribution for now, it is simple when everything is done.

@dj-neza
Copy link

dj-neza commented Mar 15, 2018

Hi guys!
I'm just wondering about how this Swift library is coming along. There is still no alternative as far as I searched and I believe a lot of people are looking for something like this. I don't have much experience, but if I can help in some way let me know.

@dileep017
Copy link
Author

@lolgear Sure Dimitry.I couldnt concentrate more on this work last month and occupied with my work. I will start writing algorithm part for HS in Swift and will update you on the progress.
@dj-neza Hey we are just starting up this.You can ask @lolgear for further updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants