From 7fe808c1d37f22db2f5ed44d21f1e10e08941311 Mon Sep 17 00:00:00 2001 From: cobalt-github-releaser-bot <95661244+cobalt-github-releaser-bot@users.noreply.github.com> Date: Thu, 14 Dec 2023 22:45:53 -0800 Subject: [PATCH] Cherry pick PR #2043: Make run_all_unittests a source_set (#2073) Refer to the original PR: https://github.com/youtube/cobalt/pull/2043 Fix ps5 modular tests which depend on base/test:run_all_unittests On PS5, the static library hidden symbols are not visible to the linked shared library. The object file hidden symbols are visible to the linked shared library Refer to error details in b/246412559#comment71 b/246412559 Co-authored-by: Niranjan Yardi --- base/test/BUILD.gn | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/base/test/BUILD.gn b/base/test/BUILD.gn index a4e3b914578d..dbfb550783b1 100644 --- a/base/test/BUILD.gn +++ b/base/test/BUILD.gn @@ -378,7 +378,9 @@ if (!is_starboard) { } } -static_library("run_all_unittests") { +# TODO: b/315170518 - Revert to static library after fixing +# symbol visibility issues for windows based modular platform builds. +source_set("run_all_unittests") { testonly = true sources = [ "run_all_unittests.cc",