Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gn.py as discussed in design review #4427

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

niranjanyardi
Copy link
Contributor

b/377271824

Set is_cobalt = false in GN code

@niranjanyardi niranjanyardi requested a review from a team as a code owner November 13, 2024 22:22
@niranjanyardi niranjanyardi marked this pull request as draft November 13, 2024 22:22
@niranjanyardi niranjanyardi force-pushed the gn_py_changes branch 3 times, most recently from 8c11c72 to feb328c Compare November 13, 2024 23:59
@niranjanyardi niranjanyardi requested review from briantting and removed request for briantting November 14, 2024 01:03
@niranjanyardi
Copy link
Contributor Author

Copy link
Contributor

@oxve oxve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good.

@niranjanyardi niranjanyardi requested review from oxve and removed request for oxve November 19, 2024 22:57
@niranjanyardi
Copy link
Contributor Author

niranjanyardi commented Nov 19, 2024

I think this looks good.

Discussed offline, there's still work to be done in this PR. This is more like a catch all PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants