Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[media] Support progressive playback #4437

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

borongc
Copy link
Contributor

@borongc borongc commented Nov 14, 2024

This PR brings the progressive demuxer from Cobalt C25 to support progressive videos.

ProgressiveDemuxer is only enabled with media_use_ffmpeg=false and use_starboard_media=true, as Cobalt needs this for evergreen.

We should re-enable unit-tests for ProgressDemuxer (b/380335617) after this PR.

b/380285071

@borongc borongc force-pushed the android_progressive branch 4 times, most recently from 507638c to d8755dc Compare November 21, 2024 00:28
@borongc borongc force-pushed the android_progressive branch 6 times, most recently from 41df91f to 2c6a160 Compare November 22, 2024 18:24
@borongc
Copy link
Contributor Author

borongc commented Nov 22, 2024

Wait for #4482, and make thie PR ready for review.

@borongc borongc force-pushed the android_progressive branch 2 times, most recently from 5da0b05 to de90f36 Compare November 22, 2024 23:06
@borongc borongc marked this pull request as ready for review November 22, 2024 23:07
@borongc borongc requested review from a team as code owners November 22, 2024 23:07
@borongc borongc requested review from dahlstrom-g, jasonzhangxx, xiaomings and osagie98 and removed request for dahlstrom-g November 22, 2024 23:07
Copy link
Contributor

@niranjanyardi niranjanyardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from open commments , lgtm from a build perspective

@borongc borongc force-pushed the android_progressive branch 2 times, most recently from 3a70ca7 to daea30c Compare November 22, 2024 23:47
media/base/decoder_buffer.h Outdated Show resolved Hide resolved
media/filters/demuxer_manager.cc Outdated Show resolved Hide resolved
This PR brings the progressive demuxer from Cobalt C25 to support progressive videos.

b/322033277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants