-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[media] Support progressive playback #4437
Open
borongc
wants to merge
1
commit into
youtube:main
Choose a base branch
from
borongc:android_progressive
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borongc
force-pushed
the
android_progressive
branch
4 times, most recently
from
November 21, 2024 00:28
507638c
to
d8755dc
Compare
borongc
force-pushed
the
android_progressive
branch
6 times, most recently
from
November 22, 2024 18:24
41df91f
to
2c6a160
Compare
Wait for #4482, and make thie PR ready for review. |
borongc
force-pushed
the
android_progressive
branch
2 times, most recently
from
November 22, 2024 23:06
5da0b05
to
de90f36
Compare
borongc
requested review from
dahlstrom-g,
jasonzhangxx,
xiaomings and
osagie98
and removed request for
dahlstrom-g
November 22, 2024 23:07
niranjanyardi
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apart from open commments , lgtm from a build perspective
borongc
force-pushed
the
android_progressive
branch
2 times, most recently
from
November 22, 2024 23:47
3a70ca7
to
daea30c
Compare
osagie98
reviewed
Nov 23, 2024
This PR brings the progressive demuxer from Cobalt C25 to support progressive videos. b/322033277
borongc
force-pushed
the
android_progressive
branch
from
November 23, 2024 03:16
daea30c
to
d618c73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the progressive demuxer from Cobalt C25 to support progressive videos.
ProgressiveDemuxer is only enabled with
media_use_ffmpeg=false
anduse_starboard_media=true
, as Cobalt needs this for evergreen.We should re-enable unit-tests for ProgressDemuxer (b/380335617) after this PR.
b/380285071