Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove overwrite_args parser argument #4439

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Remove overwrite_args parser argument #4439

merged 3 commits into from
Nov 15, 2024

Conversation

niranjanyardi
Copy link
Contributor

@niranjanyardi niranjanyardi commented Nov 14, 2024 •
edited
Loading

b/377271824

@niranjanyardi niranjanyardi requested a review from a team as a code owner November 14, 2024 23:39
@niranjanyardi niranjanyardi requested review from andrewsavage1 and kaidokert and removed request for kaidokert and andrewsavage1 November 14, 2024 23:40
@niranjanyardi niranjanyardi marked this pull request as draft November 14, 2024 23:43
@niranjanyardi niranjanyardi marked this pull request as ready for review November 15, 2024 00:27
andrewsavage1
andrewsavage1 reviewed Nov 15, 2024
View reviewed changes
cobalt/build/gn.py Outdated Show resolved Hide resolved
andrewsavage1
andrewsavage1 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@andrewsavage1 andrewsavage1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I think there's some follow up work to trim down the script further

cobalt/build/gn.py Outdated Show resolved Hide resolved
cobalt/build/gn.py Show resolved Hide resolved
cobalt/build/gn.py Show resolved Hide resolved
cobalt/build/gn.py Outdated Show resolved Hide resolved
@niranjanyardi niranjanyardi merged commit f2b140a into youtube:main Nov 15, 2024
54 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsavage1 andrewsavage1 andrewsavage1 approved these changes

@kaidokert kaidokert Awaiting requested review from kaidokert

@oxve oxve Awaiting requested review from oxve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niranjanyardi @oxve @andrewsavage1