Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP-Link JetStream enable is not being sent #3271

Open
bdg-robert opened this issue Sep 16, 2024 · 6 comments
Open

TP-Link JetStream enable is not being sent #3271

bdg-robert opened this issue Sep 16, 2024 · 6 comments
Milestone

Comments

@bdg-robert
Copy link
Contributor

I'm running into an issue with enable not working for an S5500-48GP4XF. They identify as JetStream for the model, but the commands in the model file are the same as those used to pull the configuration. From what I see in the debugging, the post-login command is nil - no enable command is sent, though it does try to send the password.

I see that the post-login block was edited in PR #2796 - could this be the cause? Any thoughts, @mirackle-spb?

@skiera6
Copy link

skiera6 commented Sep 21, 2024

Can you send your config? From what I can see in the source code, it checks if enable is set to true in your configuration. If it is, it sends the enable command. If enable is set to another value, it sends that value instead.

So, if the enable variable is not set correctly or is returning nil, that would explain why the enable command isn't being sent. Double-check your entry and make sure the enable value is properly defined and accessible in your model. If you're still having trouble, sharing your configuration might help identify the issue further.

@eabeukes
Copy link

I had the same issue across several TP-Link switches. Reverting the change in PR #2796 fixes the problem. My install was working before this commit, a recent update to Oxidized then introduced this fix and no config was captured. The new code does not actually send "enable" to the switch, according to the debug logs.

@robertcheramy
Copy link
Collaborator

Thanks @eabeukes for the hint!

@eabeukes
Copy link

eabeukes commented Nov 29, 2024

EDIT: So there now is a prompt, but the "show running config" command does not get sent. The prompt before enable ends in > but post-enable ends in #
My regex is terrible, but does this need amending to suit:
# tp-link prompt prompt /^\r?([\w.@()-]+[#>]\s?)$/

@robertcheramy robertcheramy reopened this Dec 2, 2024
@robertcheramy robertcheramy added this to the 0.32 milestone Dec 2, 2024
@bdg-robert
Copy link
Contributor Author

I'm not sure about a new model. I'll share with the community what I know from my experience over the last 12 months. Keep in mind that I have no prior experience with TP-Link equipment, so if there's a model that uses a different command set, then that's new information to me. I hope this isn't a situation similar to Ubiquiti's EdgeSwitch/ToughSwitch, which have completely different command sets.

TP-Link has a new controller, Omada Pro, that is different from its current publicly available version. The new controller is currently v1.9.30.4, whereas the older Omada controller is v5.14.32.3. The new version isn't publicly available, and there's no documentation I can find. Release notes must be requested directly from a rep.

The new controller supports older models, which are called JetStream, but some models appear to lack firmware updates. Specifically, there are some model numbers of a specific hardware version that, despite showing firmware updates online, will not accept those updates. My guess is that they're attempting to bridge controller support for equipment that hasn't been replaced yet. Some switch models have received firmware updates that specifically rebrand JetStream to Omada and remove "TL-" from the model number, further complicating this issue.

Finally, there appears to be a new line of equipment, which TP-Link sometimes calls equivalent hardware. The latest hardware is in a silver chassis and has different model numbers from the older black chassis equivalents:

New Model Old Model
S5500-24F4XF TL-SG3428XF
S5500-16XF TL-SX3016F
S4500-8GP2F TL-SG2210P
S5500-24GP4F SG2428P
S5500-24GP4XF TL-SG3428XMP
S5500-24MPP4XF TL-SG3428XPP-M2

I have encountered some issues with the older switches, and RMA'd them, but as far as the CLI commands are concerned, they seem to be the same. The commands seem nearly identical to Cisco CLI, though it's been several years since I've had my hands on Cisco gear. Can anyone confirm if the command sets for older models are the same? I'm happy to test and verify them.

@eabeukes
Copy link

eabeukes commented Dec 2, 2024

I have encountered some issues with the older switches, and RMA'd them, but as far as the CLI commands are concerned, they seem to be the same. The commands seem nearly identical to Cisco CLI, though it's been several years since I've had my hands on Cisco gear. Can anyone confirm if the command sets for older models are the same? I'm happy to test and verify them.

I went from a "TL-SG2424 1.0" Oxidized backup directly onto a "TL-SG3428X-M2 1.0". They're both branded Jetstream, but the 3428X was released in 2023/24 so is still very new. CLI is identical across them, aside from changes for features (L2+/L3-level)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants