Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct implementation of C #45

Open
FantasyVR opened this issue Aug 21, 2020 · 2 comments
Open

Correct implementation of C #45

FantasyVR opened this issue Aug 21, 2020 · 2 comments

Comments

@FantasyVR
Copy link

FantasyVR commented Aug 21, 2020

This computation of C as following is not consistent with this line.

p.C += 4 * inv_dx * Mat::outer_product(weight * grid_v, dpos);

The above line is lack of one 1/dx according to the last page of this slide.
图片

@RobertBiehl
Copy link

@FantasyVR I think the reason is, that dos is already divided by dx. Bit hard to read, but it seems to be correct.

@FantasyVR
Copy link
Author

I think it should be
p.C += 4 * inv_dx * inv_dx * Mat::outer_product(weight * grid_v, dpos);

@FantasyVR I think the reason is, that dos is already divided by dx. Bit hard to read, but it seems to be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants