Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop importing Inter font from googleapis #188

Closed
gluck opened this issue Sep 7, 2023 · 1 comment · Fixed by #201
Closed

Stop importing Inter font from googleapis #188

gluck opened this issue Sep 7, 2023 · 1 comment · Fixed by #201
Labels
bug Something isn't working

Comments

@gluck
Copy link

gluck commented Sep 7, 2023

Hi,

default css injected by create-figma-plugin-ui base.css will import Inter font from googleapis:

@import url('https://fonts.googleapis.com/css?family=Inter:400,600&display=swap');

This is unnecessary as figma already injects/defines Inter in plugin iframe:
image

Since the introduction of plugin network restrictions, it also forces plugin authors to add fonts.googleapis.com (and fonts.gstatic.com) to manifest allowedDomains to avoid network errors on the font request (but even without, the text is properly rendered because the fontface is injected by figma, pointing to static.figma.com allowed hosting).

Can we remove it ?

Thanks.

@yuanqing
Copy link
Owner

yuanqing commented Sep 8, 2023

@gluck – Thanks for raising this; TIL! Will be sure to include in the next release 👍

@yuanqing yuanqing added the bug Something isn't working label Sep 10, 2023
@yuanqing yuanqing mentioned this issue Oct 17, 2023
@yuanqing yuanqing linked a pull request Oct 17, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants