Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing up/down arrow keys in a dropdown menu shouldn't scroll the page #194

Closed
fwextensions opened this issue Sep 18, 2023 · 0 comments · Fixed by #201
Closed

Pressing up/down arrow keys in a dropdown menu shouldn't scroll the page #194

fwextensions opened this issue Sep 18, 2023 · 0 comments · Fixed by #201
Labels
bug Something isn't working

Comments

@fwextensions
Copy link

When the dropdown menu is open, pressing up/down arrow keys should move the selection, but shouldn't cause the page to scroll. I think the handleScrollableMenuKeyDown() function just needs to call preventDefault() to swallow the key events.
@yuanqing yuanqing added the bug Something isn't working label Oct 17, 2023
@yuanqing yuanqing mentioned this issue Oct 17, 2023
Merged
@yuanqing yuanqing linked a pull request Oct 17, 2023 that will close this issue
v2.7.0 #201
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v2.7.0 yuanqing/create-figma-plugin
2 participants
@fwextensions @yuanqing