Generating sandbox-bundled manifests via root Makefile (flyteorg#4940)

Signed-off-by: Ryan Lo <[email protected]>
yubofredwang · Mar 26, 2024 · bc279f1 · bc279f1
1 parent 4e13d5a
commit bc279f1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/Makefile b/Makefile
@@ -37,6 +37,7 @@ kustomize:
 .PHONY: helm
 helm: ## Generate K8s Manifest from Helm Charts.
 	bash script/generate_helm.sh
+	make -C docker/sandbox-bundled manifests
 
 .PHONY: release_automation
 release_automation:

diff --git a/docker/sandbox-bundled/Makefile b/docker/sandbox-bundled/Makefile
@@ -15,12 +15,15 @@ flyte: FLYTECONSOLE_VERSION := latest
 flyte:
 	$(foreach arch,amd64 arm64,$(call FLYTE_BINARY_BUILD,$(arch)))
 
-.PHONY: manifests
-manifests:
-	mkdir -p manifests
+.PHONY: dep_update
+dep_update:
 	helm dependency update ../../charts/flyteagent
 	helm dependency update ../../charts/flyte-binary
 	helm dependency update ../../charts/flyte-sandbox
+
+.PHONY: manifests
+manifests:
+	mkdir -p manifests
 	kustomize build \
 		--enable-helm \
 		--load-restrictor=LoadRestrictionsNone \
@@ -35,7 +38,7 @@ manifests:
 		kustomize/complete-agent > manifests/complete-agent.yaml
 
 .PHONY: build
-build: flyte manifests
+build: flyte dep_update manifests
 	[ -n "$(shell docker buildx ls | awk '/^flyte-sandbox / {print $$1}')" ] || \
 		docker buildx create --name flyte-sandbox \
 		--driver docker-container --driver-opt image=moby/buildkit:master \