You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now the way this code works, it will be pretty hard to build correctly w/ conda. We need to pre-build all .so's in the package and cannot build anything at runtime. Also, the compiler is hardcoded which won't work with conda's build tools.
I'd suggest the following changes
add an option to the setup.py to build the .so's at install.
change the build line in make.py to use the standard env vars for the C compiler (CC) and various flags (CFLAGS). The code can substitute its own values if those env vars are not present.
You may want to use python's wrapped compiler tools to do the building in any case in order to make the package more portable.
The text was updated successfully, but these errors were encountered:
Right now the way this code works, it will be pretty hard to build correctly w/ conda. We need to pre-build all .so's in the package and cannot build anything at runtime. Also, the compiler is hardcoded which won't work with conda's build tools.
I'd suggest the following changes
You may want to use python's wrapped compiler tools to do the building in any case in order to make the package more portable.
The text was updated successfully, but these errors were encountered: