Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch for conda #3

Open
beckermr opened this issue Nov 19, 2020 · 0 comments
Open

patch for conda #3

beckermr opened this issue Nov 19, 2020 · 0 comments

Comments

@beckermr
Copy link

beckermr commented Nov 19, 2020

Right now the way this code works, it will be pretty hard to build correctly w/ conda. We need to pre-build all .so's in the package and cannot build anything at runtime. Also, the compiler is hardcoded which won't work with conda's build tools.

I'd suggest the following changes

  1. add an option to the setup.py to build the .so's at install.
  2. change the build line in make.py to use the standard env vars for the C compiler (CC) and various flags (CFLAGS). The code can substitute its own values if those env vars are not present.

You may want to use python's wrapped compiler tools to do the building in any case in order to make the package more portable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant