Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split 'basePath' based on OpenAPI standards for reverse proxies #123

Open
RedTn opened this issue Oct 11, 2017 · 0 comments
Open

Split 'basePath' based on OpenAPI standards for reverse proxies #123

RedTn opened this issue Oct 11, 2017 · 0 comments

Comments

@RedTn
Copy link

RedTn commented Oct 11, 2017 •
edited
Loading

My god I'm submitting a naming issue and I can't even name my issue....

basePath works nicely as a reverse proxy config, but the naming is confusing because it conflicts with the OpenAPI standard
https://swagger.io/docs/specification/2-0/api-host-and-base-path/
Can we either split up the documentation location to properties ['scheme', 'host', 'basePath', 'path'], or just rename 'basePath' to something else?
@RedTn RedTn changed the title 'basePath' should follow OpenAPI standards Add 'host' and 'proxy' for reverse proxies Oct 11, 2017
@RedTn RedTn changed the title Add 'host' and 'proxy' for reverse proxies Add 'host' for reverse proxies Oct 11, 2017
@RedTn RedTn changed the title Add 'host' for reverse proxies Rename 'basePath' to 'host' for reverse proxies Oct 11, 2017
@RedTn RedTn changed the title Rename 'basePath' to 'host' for reverse proxies Split 'basePath' based on OpenAPI standards for reverse proxies Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RedTn