-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide API Methods until API Key is provided and/or validated #11
Comments
Any feedback on this issue and the Pull Request? |
Could you please comment on this issue and Pull Request? If you don't like the changes, we can create a separate module. If you want something more, we can add. If you are just too busy, please let us know. Best regards. |
Sorry for the delay. Find my answer in the pull request. |
New Pull Request submitted. Per your request, I have removed the inline require and added tests. The remaining tests require an actual http GET. Do you have a preference for how this is done inside the tests? |
Any feedback on pull request #16? |
Any feedback? Need anything else before you can Pull? |
Any feedback on pull request #16? |
Completely reworked my updates based on your feedback. The changes to the module are minimal. I have added support for the 'authorizations' property of the route and the ability to call a third party authorizations plug-in which I will upload to Github shortly. |
I need to hide "protected" API methods from the Swagger UI until the API Key is provided. It would be great if there was some meta data defined on each route that said whether the route was public or protected. Public meaning "No API Key". Protected meaning "API Key present and validated".
It would be awesome if "protected" could be tied to a callback function. This would allow our application to define specific behavior based on the API Key configuration. We may offer Pro features of the application and don't want to show these API methods to Standard users.
The text was updated successfully, but these errors were encountered: